Open
Conversation
Member
|
lgtm! a lot cleaner. just need to make sure it has loss curve parity with the previous implementation :) |
Member
Author
|
check against our hivemind impl, seems to be equivalent |
Jackmin801
reviewed
Sep 24, 2024
| MixedPrecision, | ||
| ) | ||
| from torch.distributed.device_mesh import init_device_mesh | ||
| from hivemind.optim.optimizer import logger |
Member
There was a problem hiding this comment.
I think we might not need this logger from hivemind?
Member
Author
There was a problem hiding this comment.
we do, otherwise we don;t have a nice logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poc of pure fsdp diloco